feat: add test should close the connection if no handshake is received
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! I've increased the value of Unrelated, but do you mind if I mention socketioxide here? |
|
It would be really nice 😄, thanks a lot |
|
@Totodore and voilà! https://socket.io/docs/v4/#server-implementations Please ping me if you need anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the socket.io protocol, a socket.io server should drop the engine.io connection if the client did not send any handshake before the
connectTimeoutparameter.It also implies to set a connectTimeout parameter in the test server config that is greater than the
pingInterval + pingTimeoutto avoid other tests to fail.Currently it is not tested in this test-suite and it would be nice to add it.